vectordotdev / vectordotdev/vector
Implement proper buffer behavior for the prometheus sink
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 22.6k
- Forks
- 2.3k
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 146
Description
To my knowledge, the prometheus sink acks data off the buffer upon reception. This effectively renders the buffer useless for this sink. And this might be the right decision, in which case we should remove the buffer documentation for this sink, but I can also see the utility in deleting data off of the buffer when prometheus is scraped. This would provide durability for metrics data if Vector was to crash.
I would like to use this issue to document our decision there or implement the above behavior.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the prometheus sink and its buffer documentation, then trace when data is acknowledged and how scraping relates to buffer deletion. Done means either documenting the decision to remove or retain buffering for this sink, or implementing the agreed behavior and documenting it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- prometheus, rust
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100