vectordotdev / vectordotdev/vector
Flush `expired` lines before polling input at `file` source line aggregation
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 22.6k
- Forks
- 2.3k
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 146
Description
Something that came up during #1852 review. See https://github.com/timberio/vector/pull/1852#discussion_r381709627.
We should flush expired before polling inner, otherwise, we don't provide proper backpressure and the expired lines may never even flush at all if the load is super-high.
There should be many more tests for the timeout and expiration logic, and once those are done - we can safely alter details like this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the file source line-aggregation implementation and its timeout and expiration tests, then review the discussion linked from #1852. Done means expired lines are flushed before polling the inner source, with tests covering timeout, expiration, and high-load behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- stream-processing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100