vectordotdev / vectordotdev/vector
Time formats in sinks should be derived from events
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 22.6k
- Forks
- 2.3k
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 146
Description
It was unclear for me which timestamp is used for making filename. It is not documented anywhere.
My first expectation was to get there timestamp of last event, or maybe timestamp of first event.
But current timestamp is least useful in my point of view — there is a file metadata with creation time. And it doesn't name files as expected when historical data is being processed.
Seems this idea is not new for you https://github.com/timberio/vector/blob/6f290d3e55d78438100b1bd31747c6c4b1630184/src/sinks/aws_s3.rs#L318
but I couldn't find a ticket to track that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced src/sinks/aws_s3.rs location and tracing how sink filenames obtain their timestamps. Compare the available event timestamps with the current timestamp-based behavior, then document the chosen semantics and verify the affected sink behavior with the relevant tests, if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, rust
- Domain
- observability, stream-processing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100