valhalla / valhalla/valhalla

`PedestrianCost` does not prefer sidewalks by default

Open
#6,323 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
6.2k
Forks
981
Avg merge
2d 14h
Merged PRs (30d)
14

Description

I recently mapped a sidewalk separately from the carriageway that was previously just tagged on the carriageway, but noticed that once those changes trickled down into the FOSSGIS instance, Valhalla's routing did not seem to pick them up, while OSRM and GraphHopper do.

https://www.openstreetmap.org/directions?engine=fossgis_valhalla_foot&route=51.797253%2C8.552288%3B51.799858%2C8.548366#map=18/51.798561/8.550335

Image

Turns out that by default `sidewalk_factor` and `walkway_factor` are 1, and that we don't penalize any road by use or classification in any way, so naturally it takes the shortest path, which is along the main carriage way.

Contributor guide

Open the contributing guide

Research direction

Start by locating the PedestrianCost implementation and the sidewalk_factor and walkway_factor defaults described in the issue. Trace how pedestrian road use or classification affects route costing, then verify that a mapped sidewalk is preferred over the main carriageway while preserving sensible pedestrian routing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.