valhalla / valhalla/valhalla

motor_vehicle:conditional=private @ (xxxxx) not work doesn`t work as expected

Open
#3,967 7 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
6.2k
Forks
981
Avg merge
2d 14h
Merged PRs (30d)
14

Description

1, Private roads should have the lowest priority
I think we should set destination_only to true when hit conditional private
https://github.com/valhalla/valhalla/blob/d6c80412c5fbfc8e85815a6081f68624b44c03e1/src/mjolnir/pbfgraphparser.cc#L1840-L1847

like this
```
if (tmp == "private"){
way_.set_destination_only(true);
}
```

2, two scenario
for conditional private, I think there will be two scenario
```
motor_vehicle=no
motor_vehicle:conditional=private @ (16:30-07:00)
16:30-07:00 is a private road, other times are not allowed
```
We can support this function by set destination_only to true

```
motor_vehicle=yes
motor_vehicle:conditional=private @ (16:30-07:00)
16:30-07:00 is a private road, other times are allowed
```
for this scenario, I don't have any good ideas, can anyone provide an idea?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.