valhalla / valhalla/valhalla

Respond with offending source/target for `max_matrix_distance` loki error

Open
#3,958 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
6.2k
Forks
981
Avg merge
2d 14h
Merged PRs (30d)
14

Description

As discussed in https://github.com/valhalla/valhalla/issues/3898#issuecomment-1377637254, we don't want to be too lenient on clients sending matrices which exceed the distance limit on one or more pairs.

However, we could at least respond with the source/target index which triggered the exception. Of course it could be multiple source/target pairs, but I'd not enter that complication. In worst case, the client will fail multiple times in a row, it doesn't matter so much for server performance.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.