Incorrect path edges if location snaps to a node
- Dominant language
- C++
- Stars
- 6.2k
- Forks
- 981
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 14
Description
I noticed that in unidirectional astar algorithms we handle cases when location snaps exactly to the node not always correctly.
**TimedepForward**
A simple example:
```
A--------1----B
```
Let's suppose we build route from `A` to `1`. In this case we will not filter out edge `BA` (opposing to `AB`) and will get the path route `BA AB` instead of `AB`. Something wrong with logic that handles trivial paths: https://github.com/valhalla/valhalla/blob/master/src/thor/timedep_forward.cc#L448 .
**TimedepReverse**
I've noticed this https://github.com/valhalla/valhalla/blob/master/src/thor/timedep_reverse.cc#L549 - we skip **outbound** path edges for the origin (instead of inbound).
Contributor guide
Assessment
This issue has not been assessed yet.