valhalla / valhalla/valhalla

Tile Expanded Integrity Check, Still Lightweight

Open
#2,682 0 comments 1 reaction 0 assignees View on GitHub
cleanup
Dominant language
C++
Stars
6.2k
Forks
981
Avg merge
2d 14h
Merged PRs (30d)
14

Description

At the moment we have a pretty relaxed check when we load a graphtile into memory and initialize its internal pointers. We do 2 things:

1. we check that the tile is large enough to contain at least a tile header
2. we check that the size of the tile matches the size reported in the tile header

We should do just a little bit more, specificaly, when we do pointer arithmetic to set the various pointers to the various data structures in the tile we should also make sure that none of them go past the end of the the address range that the tile is supposed to encompass (based on its size)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.