DefaultViewCache does not destroy the previous bean store created if it was not activated
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 186
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
Hi all,
in vaadin-spring v3.1.1, if I create a new View by calling method of ViewCache:
void creatingView(String viewName);
the related bean store is created and also the view scope with all beans.
But in the DefaultViewCache implementation the view is completely activated only when is called the method void viewActivated(String viewName).
So if the first method is called and the navigation is forced to another view (maybe also the same), the bean store is not destroyed causing an inconsistent state.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the DefaultViewCache implementation, starting with creatingView(String viewName) and viewActivated(String viewName), and trace how the related bean store is managed. Confirm the lifecycle when navigation moves to another view or the same view without activation; done means the previously created, unactivated bean store is destroyed and no inconsistent state remains.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100