Don't use custom Spring servlet, Spring service, Spring session
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 186
- Forks
- 98
- PR merge metrics
- No merged PRs in 30d
Description
@denis-anisimov commented on Wed Oct 11 2017
At the moment there are a number of class that are implemented for Spring: service, servlet, session.
It should be possible for the developer to create it's own implementations so that he doesn't know anything about a custom Spring vaadin servlet.
There should be a SpringInstantiator which is registered via Java SPI.
To be able to keep Instantiator concept extensible we should change the implementation of creating/searching available Instantiator classes. If there is a several eligible classes then we should check the hierarchy. If they are subclasses of each others then just select the subclass.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing custom Spring service, servlet, and session implementations, then trace how Instantiator classes are currently created and searched. Review the Java SPI requirement and the proposed subclass-selection behavior. Done means developers can provide their own implementations without depending on a custom Spring Vaadin servlet, with eligible Instantiators resolved by hierarchy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring, spring-boot
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100