Spreadsheet shows touch indicators when using on desktop with mouse and keyboard.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 50
- Forks
- 53
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 1
Description
Spreadsheet has to modes: touchMode=true and touchMode=false. Which one is used is determined by asking GWT's TouchEvent class. https://github.com/vaadin/spreadsheet/blob/master/vaadin-spreadsheet/src/main/java/com/vaadin/addon/spreadsheet/client/SpreadsheetWidget.java#L196
setTouchMode(TouchEvent.isSupported());
This means that desktops with touch screens will be reported as touch devices. This can't be overriden in any way - it is done on the client side.
The side effect of this is that desktop devices with touch screens will show a bunch of touch indicators which are obtrusive when working with Spreadsheet. The biggest culprit of them all is the mobile-device-oriented "fill"-button that pops up every time you select a row. It block reading data above the cell you are typing in. Link to code that puts it on the screen here.
There is no way to configure the boolean touchMode, and you can't hide the popup with CSS as it does not have any spreadsheet specific class names and it is within body in the DOM.
- The feature needs to be better targeted towards primary touch devices
- Touchmode should be possible to disable by server side api
- The popup should have a unique class name
- The gesture for opening the menu should not be a simple touch, a long touch would for example work better.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in vaadin-spreadsheet/src/main/java/com/vaadin/addon/spreadsheet/client/SpreadsheetWidget.java around the TouchEvent.isSupported() call, then inspect SelectionWidget.java around the fill-button logic. Determine how touch mode is selected and how the popup is created; done means desktop touch devices no longer show obtrusive touch indicators while touch use remains supported, with the requested server-side control and popup identification addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100