vaadin / vaadin/observability-kit

Decide between vaadin.db.fetch.rows and vaadin.data.fetch.rows

Open
#376 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Java
Stars
7
Forks
5
Avg merge
2d 16h
Merged PRs (30d)
25

Description

feat/data-query-metrics adds vaadin.data.fetch.rows and vaadin.data.fetch.requested, measured at the data provider layer. vaadin.db.fetch.rows measures at the JDBC layer, requires DataSource proxying, and is opt-in behind vaadin.observability.database.

The two now overlap substantially and the names are almost identical. The data provider meter covers the common "which view reads too much" case, works for non-JDBC data providers, and needs no proxying.

Decide before both ship in 5.0
  • Keep both, with documentation making clear when each applies.
  • Or demote vaadin.observability.database further.
  • Or drop the JDBC row counting and keep vaadin.db.query for per query spans only.

Shipping two near-identically named row count summaries with different capture points is the outcome to avoid.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the data-provider metrics from feat/data-query-metrics with the JDBC-layer metrics behind vaadin.observability.database, including vaadin.data.fetch.rows, vaadin.data.fetch.requested, and vaadin.db.fetch.rows. Decide whether to keep both, further demote database observability, or retain only vaadin.db.query spans; done means the two near-identically named row-count summaries no longer overlap ambiguously before 5.0.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases, observability
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.