vaadin / vaadin/framework

Close Grid Unbuffered Editor when pressing enter on last row

Open
#9,738 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement workaround
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Enter is the key that moves the Grid unbuffered editor to the next row by default. Pressing ENTER on the last row right now does nothing. It could close the editor overlay. This needs a UX opinion.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the Grid unbuffered editor's handling of Enter on the last row and any related tests or entry points. Clarify the UX decision first: determine whether Enter should close the editor overlay, then update the behavior and verify that Enter still advances editing on other rows.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.