vaadin / vaadin/framework

FieldBinder not compatible with Vaadin Designer

Open
#9,462 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question Stale
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Current FieldBinder in Vaadin 8.0 is trying to map components to fields (class) based on caption of component. This is causing issue with Vaadin Designer where only correct mapping is the name of component.

Steps
  1. Create new design with Vaadin Designer
  2. Have one component with name "add" and then another component with caption "add"
  3. Try to use design in your application
Expected outcome

Only the component with name "add" should be mapped to field. Design should load correctly.

Actual outcome

Initialisation of design fails as field binder is trying to pair also the other component to same field.

Based on Vaadin Design team they are the only customer of this functionality (I have no idea if that is true), so they asked to file bug for framework.

Issue is in FieldBinder.bindField method

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the FieldBinder.bindField method named in the issue and reproduce the Vaadin Designer steps with components whose name and caption both equal "add". Confirm that only the component named "add" is mapped and that the design loads without an initialization failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.