vaadin / vaadin/framework

Valo theme Grid styles in FW8

Open
#8,514 7 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

candidate enhancement
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Table was moved to compatibility package in FW8, in favor of Grid. Valo, which is still the main theme, has many useful styles for Table, such as:

  • ValoTheme.TABLE_NO_STRIPES
  • ValoTheme.TABLE_NO_VERTICAL_LINES
  • ValoTheme.TABLE_NO_HORIZONTAL_LINES
  • ValoTheme.TABLE_BORDERLESS
  • ValoTheme.TABLE_COMPACT
  • ValoTheme.TABLE_SMALL

These styles would be really useful also for Grid.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing ValoTheme Table styles with the Grid APIs, noting that Table moved to the compatibility package in FW8. Define equivalent Grid styles for TABLE_NO_STRIPES, TABLE_NO_VERTICAL_LINES, TABLE_NO_HORIZONTAL_LINES, TABLE_BORDERLESS, TABLE_COMPACT, and TABLE_SMALL, then verify that each style is available for Grid.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.