vaadin / vaadin/framework

Confirmation message support for Binder

Open
#8,387 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

@Artur- commented on Wed Aug 03 2016

binder.forField(emailField)
  .withValidator(new EmailValidator(
    "This doesn't look like a valid email address"))
  .withConfirmationMessage(
    email -> email + " looks like a valid email address");
  .bind(Person::getEmail, Person::setEmail);

The default handler shows confirmation messages in a status label, if set. It is not set as a "component error". IF there is a custom handler, then it can decide what to do with the message.


@pleku commented on Tue Oct 11 2016

SHOULD HAVE, but not necessary for FW8.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Binder's validation flow and the default and custom validation message handlers. Implement confirmation-message support for field bindings, with the default handler using a status label and custom handlers deciding how to display it; done means the proposed Binder API and behavior work as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.