vaadin / vaadin/framework

Grid should not add container properties as columns on setContainerDataSource()

Open
#8,258 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Stale v7
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Grid should not add a column for each container property right on the new container is set.
It should instead wait for beforeClientResponse() to lazily add the columns only if it still has no columns explicitly added from the user.

See Grid.java:5032

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in server/src/main/java/com/vaadin/ui/Grid.java around line 5032 and trace setContainerDataSource() through beforeClientResponse(). Done when container properties are not turned into columns immediately, and lazy column creation occurs only when no columns were explicitly added by the user.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.