vaadin / vaadin/framework

Window or Popup can not be closed with <ESC> Key

Open
#7,628 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Stale v7
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by roth@hlp.de


If you have a closable Window or Popup and tab the focus to the
close buton, tabstop.top or tabstop.bottom (They have tabindex set in DOM tree).

You can not close the window with the Key.
If you Tab to an index inside the scrollable or the scollable itself, you can close the window.

Additional, you can not press ENTER or SPACE to trigger the close button if it has the focus (like a normal button or link).

For Usibility its also strange to have 2 Tab in front with no visual response (scrollable and tabStop.top) and one at the end (tabStop.bottom).


Imported from https://dev.vaadin.com/ issue #19781

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using a closable Window or Popup, focusing the close button, tabstop.top, tabstop.bottom, the scrollable area, and the scrollable itself. Trace the Window or Popup keyboard and focus handling; done means ESC closes it from every relevant focus target and ENTER or SPACE activates a focused close button.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.