vaadin / vaadin/framework

Make it easy to use font icons of various sizes

Open
#7,176 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement valo
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by @Artur-


When using FontAwesome directly you have the possibility to easily use 6 different sizes of the icons (see e.g. http://fortawesome.github.io/Font-Awesome/icon/500px/). When using Font Awesome in a Vaadin application, you only have the possibility to use one size of the icon e.g. as a Button icon button.setIcon(FontAwesome.SAVE).

There should be a way to easily use a "small","large","huge" icon for a button through the Java API.

Either as

button.setIcon(FontAwesome.SAVE_SMALL)

or by some other means


Imported from https://dev.vaadin.com/ issue #18980

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the FontAwesome.SAVE value and the button.setIcon(FontAwesome.SAVE) entry point mentioned in the issue. Determine how icon sizing is represented and whether the requested small, large, and huge variants fit the existing Java API; done means a button can select multiple icon sizes through the API with appropriate coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.