Can't modify Version for theme caching
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Originally by micael.kirouac@telus.com
Some nice changes were made to better support caching of themes when upgrading vaadin version: https://dev.vaadin.com/changeset/65904ffbdebc861a45c1b504d244d02a12f4561b/vaadin.
This is fine. However, if we modify our theme without changing version, we still have the caching problem. It would be nice if we had a way to modify that version or append something to it like "customer-version".
Another alternative would be to have the setupMainDiv method protected so we could override it, or to have a getVersion() method inside BootstrapHandler.
By the way the comment of the setupMainDiv method states "Override this method if you want to add some custom html around around the div element into which the actual Vaadin application will be rendered" but it is private.
Imported from https://dev.vaadin.com/ issue #18495
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading BootstrapHandler and the setupMainDiv method mentioned in the issue, then trace how the theme version is used for caching. Compare the requested customization options and define a verifiable way for modified themes to avoid stale cached resources.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- web-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100