vaadin / vaadin/framework

Grid header row start to disappear after confirming removing item

Open
#6,813 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Stale v7
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by lipodido


start new project ( to be sure that is not related to my project or my custom css)
by using the vaadin example about grid from https://github.com/Legioth/AllAboutGridWebinar
Upgrade to vaadin 7.4.5 and modify the Order bean to add delete button column
add the following code and the two attached simple class:

grid.getColumn("button").setRenderer(new ButtonRenderer(new com.vaadin.ui.renderers.ClickableRenderer.RendererClickListener() {
            @Override
            public void click(RendererClickEvent event) {
                // TODO Auto-generated method stub
                final ConfirmationDialogPopupWindow confirmPopup = new ConfirmationDialogPopupWindow(
                        "Confirm title", "Confirm deletion");
                confirmPopup.setItemId(grid.getSelectedRow());
                confirmPopup.addListener(new ConfirmationEventListener() {
                    protected void rejected(ConfirmationEvent event) {
                    }

                    protected void confirmed(ConfirmationEvent event) {
                        grid.getContainerDataSource().removeItem(grid.getSelectedRow());
                    }
                });
                confirmPopup.showConfirmation();
            }
        }));

After selecting item and clicking the delete button the header row (or extraheader )start to disapear (-2px approximately) and if i scroll the headers appear again !

The issue disappear if the horizontal scroll is visible ( not all column are visible = width not 100% or grid is not sizefull )
by making :

grid.setHeight("700px");
grid.setWidth("900px");

the isse disappear
by making

grid.setSizeFull();

The issue comeback again


Imported from https://dev.vaadin.com/ issue #18153

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the AllAboutGridWebinar example and the shown ButtonRenderer deletion code. Compare a fixed-size grid with grid.setSizeFull(), then inspect the Grid header or extraheader behavior after removeItem(grid.getSelectedRow()). Done means the header remains visible after confirmation, removal, and scrolling when the grid is full size.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.