Components in Grid header should affect the header height
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Originally by @Ansku
By default, when you add a Button (or any other component that is higher than default text) to a Grid header cell, the bottom of that Button will get cut off, making it look like a tab instead. It's possible to give the header a fixed height that goes around this problem, but there doesn't seem to be any way to treat the height as undefined, so that it would adjust to the contents.
Imported from https://dev.vaadin.com/ issue #17545
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a Grid header cell containing a Button or another component taller than default text. Inspect the Grid header sizing behavior and any related tests or entry points you locate. Done means the header height adjusts to its contents without cutting off the component, while fixed-height headers continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100