Provide 'warning' style for Labels similar to 'success' and 'failure' styles in Valo theme
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Originally by davidb
Currently the Valo theme provides two styles for Labels, 'success' and 'failure'. A 'success' label gets a green border and a tick icon, a 'failure' label gets a red border and a failure icon.
In our opinion, a corresponding 'warning' Label style would be generally useful as a middle ground.
- Suggested FontAwesome icon is U+F071, that is, the 'warning' icon.
- Suggested colour is orange (for example
#EDAC3B, you will probably know better). - Suggested style name is
warning. Incom.vaadin.ui.themes.ValoTheme:
public static final String LABEL_WARNING = "warning";
Please consider providing this 'warning' style for Labels in the Valo theme.
Thanks.
Imported from https://dev.vaadin.com/ issue #16925
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at com.vaadin.ui.themes.ValoTheme and inspect the existing success and failure Label styles in the Valo theme. Add the warning style using the requested name, icon, and orange color, then verify that the theme exposes and renders it consistently with the existing styles.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100