vaadin / vaadin/framework

Implement a RTL support for client side "helper" widgets

Open
#6,226 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by @johannest


Implement a RTL support for the client-side "helper" widgets. At least widgets below have to supported. Assumed changes/tasks are listed below of each widgets.

VTooltip & TooltipInfo
- get direction from owner (if it is HasDirection) by implementing setOwner
- description element css
- testing (manual and TB tests)
VErrorMessage
- get direction when setOwner is called
- RTL css
- testing (manual and TB tests)
VCaption
- get direction from owning component
- mirrored Icon placement
- css for captionText
- css for errorIndicatorElement and requiredFieldIndicator
- testing (manual and TB tests)
com.vaadin.client.ui.FontIcon and ImageIcon
- css
- testing (manual and TB tests)
VOverlay
- ???
VLoadingIndicator
- mirrored
- testing (manual and TB tests)
VContextMenu
- get direction from actionOwner??
- CMenuBar
- show menu on the left side of the cursor
- open nested menus on the left side (can there be nested context menus??)
- css for menu item
- icons on the right side
- testing (manual and TB tests)
vaadin.client.ui.Action
- get direction from actionOwner??
- icon and caption reversed + css for caption
- testing (manual and TB tests)
VUI / UIConnector
- direction for loading indicator
- direction for notifications


Imported from https://dev.vaadin.com/ issue #16545

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the named client-side entry points: VTooltip, VErrorMessage, VCaption, FontIcon, ImageIcon, VOverlay, VLoadingIndicator, VContextMenu, Action, VUI, and UIConnector. Review existing manual and TB tests, then map the listed direction, mirroring, CSS, menu, and notification requirements to those classes. Done means the listed widgets support RTL consistently and the manual and TB tests cover the behavior; VOverlay and action-owner direction still need clarification.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, java
Domain
frontend, internationalization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.