vaadin / vaadin/framework

vaadin-theme fonts inline generation option - using data-url - with vaadin-sass-compiler

Open
#5,924 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement valo
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by santeriv-profit


To make styles.css even more responsible of look-and-feel. And no extra requests for files caused by .css. :)

Example here http://jsfiddle.net/yjmkdvqn/

As those three open-sans font files 300(light),400(regular),600(semibold) were part of default valo-theme.

Above example base64 strings were generated from Vaadin 7.3.4 () using base64 cmdline tool

#!bash
base64 -w 0 OpenSans-Semibold-webfont.woff > OpenSans-Semibold-webfont.woff.txt

.woff-filetype selection was made based on this : http://caniuse.com/#feat=woff


Imported from https://dev.vaadin.com/ issue #15283

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the vaadin-theme and vaadin-sass-compiler handling for the default valo-theme and its Open Sans font files. Review how styles.css is generated and how the compiler currently references .woff files. Done means the requested option can inline the fonts as data URLs in styles.css without separate font requests; the issue names no tests to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
sass
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.