Table header texts are not shown anymore when theme is switched from Valo to non-Valo theme
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Originally by winfried.stenzel
When the theme is changed from a Valo theme to a non-Valo theme, table header texts are not shown anymore.
Steps to reproduce:
- go to vaadin table sampler (http://demo.vaadin.com/sampler/#ui/data-presentation/table)
- change the theme to Reindeer (or Runo or Chameleon) by clicking on the editor button and the tab "Theme"
The table header texts ("Country", "Code") are not shown anymore.
This happens with Firefox 33.0.1 and Internet Explorer 11.
Assumption:
In my application the header captions do appear even for Reindeer, Runo and Chameleon if one of these themes is the theme used for the @Theme annotation, i.e. as initial theme. There seems to be a problem in UI.setTheme(). Perhaps some sort of cache/initialization is not updated?
Imported from https://dev.vaadin.com/ issue #15195
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the problem in the Vaadin table sampler by switching from a Valo theme to Reindeer, Runo, or Chameleon. Start at the UI.setTheme() entry point and trace how table header captions are handled during the theme change; done means the “Country” and “Code” headers remain visible after switching themes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100