vaadin / vaadin/framework

AbstractField.setPropertyDataSource shouldreport error for invalid datasources

Open
#575 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement v7
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by @mstahv


Button b = new Button();
b.setPropertyDataSource(new ObjectProperty("A"));

produces no error whatsoever even though the datasource produces values of invalid type.

   } catch (final Throwable e) {
            currentBufferedSourceException = new Buffered.SourceException(this,
                    e);
            modified = true;
        }

currentBufferedSourceException is set but never shown.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at AbstractField.setPropertyDataSource and the catch block that assigns currentBufferedSourceException. Reproduce the Button/ObjectProperty example, then trace where that stored exception is expected to be surfaced. Done means an invalid datasource produces a visible error instead of being silently ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.