Window shadow is hard to disable
Open
Nobody has claimed this yet.
enhancement
valo
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Originally by CodingFabian
Look at attached screenshot (taken from valo theme demo). The window is styled twice.
One time with 0 2px and one time with 0 4px
When I set $v-window-shadow: false, then the 0 2px shadow goes away, but the other remains.
Imported from https://dev.vaadin.com/ issue #14633
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Valo theme demo case described in the issue and inspect the window's generated styles, focusing on the $v-window-shadow setting. Done means setting the variable to false removes both the 0 2px and 0 4px shadows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- sass
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100