vaadin / vaadin/framework

GWT file lists only 5 of 6 user.agent values in its comments. (Vaadin 7.1.13)

Open
#5,047 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Stale v7
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by basil.bourque


In a new Vaadin 7.1.13 project created by the Vaadin Plugin for NetBeans, when running in NetBeans 8 and Java 8 on Mac OS X (Mavericks)…

The "AppWidgetSet.gwt.xml" files contains comments guiding the programmer to add an element to specify a subset of user agents. The comments describe 5 such values for the "user.agent" tag: ie8,ie9,gecko1_8,safari,opera.

But that list contains 5 values while 6 permutations are reported as compiling in the NetBeans output pane. Apparently another value is missing from those comments.


Imported from https://dev.vaadin.com/ issue #13559

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the AppWidgetSet.gwt.xml comments described in the issue and compare their user.agent list with the six permutations reported in the NetBeans output pane. Update the comments so they document all six values, then verify that the guidance matches the generated project configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.