vaadin / vaadin/framework

Style name on Action

Open
#4,593 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement v6 v7
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by sascha.broich


Currently it is not possible to give an Action a style.
This would be a nice improvement for then the context menu entries in Table and Tree could be customized by CSS.

We use a sprite for the action icons and need for this style classes on the context actions.
For our old Vaadin 6.4 I have patched the Vaadin code. But for our upgrade to Vaadin 7 I would rather not have to patch the Vaadin code itself for it is then hard to update to the newest.


Imported from https://dev.vaadin.com/ issue #12824

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Action API and the Table and Tree context-menu entry rendering. Trace how action entries are generated and how CSS classes are currently assigned, then determine where a style name could be exposed. Done means actions can carry a style name that is applied to the corresponding context-menu entries without patching the framework.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.