AbstractCommunicationManager methods not depending on internal state should be moved
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Originally by @jdahlstrom
AbstractCommunicationManager contains utility methods that do not depend on ACM state. These should be moved to an Util class if they don't seem to fit anywhere else.
encodeState
getStreamVariableTargetUrlgetConnector(depends on DnD service; see https://github.com/vaadin/framework/issues/3704)handleConnectorRelatedExceptionisConnectorVisibleToClientisComponentVisibleToClientgetDirtyVisibleConnectors(should be removed)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading AbstractCommunicationManager and tracing the listed methods to confirm which ones use manager state. Review issue 3704 for the getConnector dependency, then move suitable utilities to an appropriate Util class and remove getDirtyVisibleConnectors; done means the methods no longer inappropriately depend on ACM state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100