vaadin / vaadin/framework

Navigator should not make assumptions on navigation string format

Open
#2,733 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Originally by @jdahlstrom


Currently, even though it is ViewProvider's job to parse a textual navigation state into a View instance and parameters, Navigator makes some assumptions on the format of the navigation string - specifically that it looks like "viewname/parameters". It should probably be ViewProvider's responsibility to also offer reverse mapping -- this would also enable things like navigateTo(MyView.class, params) (see also https://github.com/vaadin/framework/issues/2519)


Imported from https://dev.vaadin.com/ issue #9435

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Navigator and ViewProvider responsibilities described in the issue, including how navigation strings become View instances and parameters. Review issue #2519 for related context; done should remove Navigator's assumptions about the string format and support reverse mapping for class-based navigation such as navigateTo(MyView.class, params).

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.