VBrowserDetails.isEdge() doesn't work for all cases anymore
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
According to https://blogs.windows.com/msedgedev/2019/04/08/microsoft-edge-preview-channel-details/ , chapter "User Agent String", Chromium Edge's user agent is now Edg/ instead of the Legacy Edge's edge/.
Given that there are several differences between these two, and also that Legacy Edge is not supported from V15+ on, a isLegacyEdge() method could be created so that isEdge() would be deprecated and simply call isLegacyEdge and a new isChromiumEdge() could be created, this last one searching for the new user agent feature Edg/
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at VBrowserDetails and review how the existing isEdge() check handles the legacy edge/ user-agent string. Compare that behavior with the Edg/ user-agent described in the linked Microsoft Edge article; done means legacy and Chromium Edge can be distinguished through the proposed methods, with the existing method deprecated as requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100