vaadin / vaadin/framework

VScrollTable pagelength is set to 0 when table has size lower than displaying 1 row completely breaking lazy loading

Open
#12,171 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Stale v7
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

https://github.com/vaadin/framework/blob/aa3757c6649fa056b9495500d6987d213a8bb782/compatibility-client/src/main/java/com/vaadin/v7/client/ui/VScrollTable.java#L6866

This is a huge bug because if you have resizable table (such as in split panel) if you resize table to 0 (hiding it), it will completely disable lazy loading, loading all items from database!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in compatibility-client/src/main/java/com/vaadin/v7/client/ui/VScrollTable.java at line 6866 and trace how pagelength is calculated when fewer than one row fits. Reproduce by resizing a resizable table to zero height, then verify that lazy loading remains enabled instead of loading all database items.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.