vaadin / vaadin/framework

TreeGrid: a bit inconsistent click handling with details row.

Open
#11,700 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Stale
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Repeatedly clicking on a TreeGrid row that has details sometimes doesn't open or close the details row but just changes the selection. Trying again gives the expected results. Double-clicking also behaves a bit inconsistently (no double-click handling added to the test class). Tested on Chrome 76 / Windows 7 with TreeGridDetailsManager on master branch and with #11438.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior with TreeGridDetailsManager on the master branch, using the issue's repeated-click and double-click cases. Inspect the existing TreeGrid details handling and its test class, then verify that clicks consistently open or close the details row rather than only changing selection, including the double-click case.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.