vaadin / vaadin/framework

Replacing screenshot tests with sensible code tests

Open
#11,685 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Epic Stale
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

screenshot tests are not stable and it causes a lot of problems i.e: unstable tests.

pay more attention to the following tests:

DateFieldReadOnlyTest #11867 
DateTimeFieldReadOnlyTest #11870 

VaadinIconSetTest
ValoThemeUITest

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading and running the named tests: DateFieldReadOnlyTest, DateTimeFieldReadOnlyTest, VaadinIconSetTest, and ValoThemeUITest. Identify which assertions depend on screenshots and replace those checks with stable code-level tests. Done means these tests verify the same behavior without screenshot comparisons.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.