ComboBox dropdown list style is not affected by ComboBox style
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Hi,
I'm using vaadin framework 8.8.0, on win7 x64, tomee 7.
I have spotted that ValoTheme styles like ValoTheme.COMBOBOX_SMALL are applied only to ComboBox input-field, but not to items in drop-down list. I think, the drop-down should use the same style as is set for ComboBox.
You can see it in "Valo Theme Test" demo app demo. See the Tiny or Huge ComboBoxes. The input field is of that style, but items in dropdown menu are always of the normal style.
Example: If you want to create app for touch screen and want huge component sizes, then the normal-sized items in dropdown can be problem to touch by fingers.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Valo Theme Test demo and compare the ComboBox input-field styling with the dropdown items for the Tiny, Huge, and other size variants. Trace where ValoTheme ComboBox styles are applied, then verify that the dropdown items use the selected size and that the touch-screen case is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100