Added option to ignore folders without style definitions during theme compilation
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Relates to #7848
This problem still persists in Vaadin 8.7.2 and applies to Subversion, CVS, Dimensions and probably others.
I added the ignoreNonThemeFolders option to the vaadin-maven-plugin and created PRs in vaadin/maven-plugin and vaadin/sass-compiler.
(https://github.com/vaadin/maven-plugin/pull/116 and https://github.com/vaadin/sass-compiler/pull/321)
With this option set to true the plugin looks for styles.scss in all folders under src/main/webapp/VAADIN/themes and will ignore failures due to folders created by versioning systems that do not contain a style definition. Information about failed attempts is printed to the console.
You can use it via
<configuration>
<ignoreNonThemeFolders>true</ignoreNonThemeFolders>
</configuration>
in the vaadin-maven-plugin
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vaadin/maven-plugin#116 and vaadin/sass-compiler#321, since the proposed work is already located in those repositories rather than this issue's repository. Check the handling of ignoreNonThemeFolders and the documented Maven configuration; done means the option is available and failed attempts for non-theme folders are reported as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 20/100