vaadin / vaadin/framework

Added option to ignore folders without style definitions during theme compilation

Open
#11,545 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Relates to #7848

This problem still persists in Vaadin 8.7.2 and applies to Subversion, CVS, Dimensions and probably others.
I added the ignoreNonThemeFolders option to the vaadin-maven-plugin and created PRs in vaadin/maven-plugin and vaadin/sass-compiler.
(https://github.com/vaadin/maven-plugin/pull/116 and https://github.com/vaadin/sass-compiler/pull/321)

With this option set to true the plugin looks for styles.scss in all folders under src/main/webapp/VAADIN/themes and will ignore failures due to folders created by versioning systems that do not contain a style definition. Information about failed attempts is printed to the console.

You can use it via

  <configuration>
        <ignoreNonThemeFolders>true</ignoreNonThemeFolders>
   </configuration>

in the vaadin-maven-plugin

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with vaadin/maven-plugin#116 and vaadin/sass-compiler#321, since the proposed work is already located in those repositories rather than this issue's repository. Check the handling of ignoreNonThemeFolders and the documented Maven configuration; done means the option is available and failed attempts for non-theme folders are reported as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.