vaadin / vaadin/framework

HierarchicalQuery#getOffset always rerurns 0

Open
#11,447 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Hi,
I'm using TreeGrid with a HierarchicalDataProvider, but HierarchicalQuery's offset is always equals 0 according to the following code:
https://github.com/vaadin/framework/blob/2d806a59509fa818b35e75998ed42df674c93122/server/src/main/java/com/vaadin/data/provider/HierarchyMapper.java#L493
Is there any bug or HierarchicalDataProvider shouldn't be used with very big trees?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at server/src/main/java/com/vaadin/data/provider/HierarchyMapper.java around line 493, where HierarchicalQuery#getOffset is reported to return 0. Reproduce the behavior with a TreeGrid using a HierarchicalDataProvider, then check whether offsets are expected to support large trees and determine what the observed result should be.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.