Upload takes a lot of time when active HTTP debug
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Vaadin 8.5.1
When debugging http, file uploads take a really long time. It's probably because the input stream between HttpInput and FileUploadHandler is not buffered.
see:
com.vaadin.server.communication.FileUploadHandler$SimpleMultiPartInputStream.read()
and:
org.eclipse.jetty.server.HttpInput: read()
if (LOG.isDebugEnabled()) {
LOG.debug("{} read {} from {}", new Object[] { this, Integer.valueOf(l), item1 });
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting com.vaadin.server.communication.FileUploadHandler$SimpleMultiPartInputStream.read() and org.eclipse.jetty.server.HttpInput.read(), focusing on the debug logging shown in the report. Reproduce a file upload with HTTP debugging enabled and compare its timing with debugging disabled; done means uploads no longer take excessively long when HTTP debug is active.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100