Browser version/engine parsing error.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
-
Vaadin Framework: 8.5.1
-
Web container: Springboot 1.5.12.RELEASE (Embedded Tomcat 8.5.29)
-
Description of the bug
My production env starts to receive theses logs on this last week.
VBrowserDetails cannot parse this user-agent:
mozilla/5.0 (windows; u; windows nt 5.1; en-us; rv:x.x.x) gecko/20041107 firefox/x.x
Prints on console:
Browser engine version parsing failed for: mozilla/5.0 (windows; u; windows nt 5.1; en-us; rv:x.x.x) gecko/20041107 firefox/x.x
Browser version parsing failed for: mozilla/5.0 (windows; u; windows nt 5.1; en-us; rv:x.x.x) gecko/20041107 firefox/x.x
-
Minimal reproducible example
Just send a request to vaadin using
mozilla/5.0 (windows; u; windows nt 5.1; en-us; rv:x.x.x) gecko/20041107 firefox/x.x
as user-agent -
Expected behavior
Detect as firefox? over windows xp?
Use a logger framework to be possible disable console messages on production. -
Actual behavior
Print on System.err trace messages.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating VBrowserDetails and reproduce the issue with the user-agent shown in the report. Check how browser and engine versions are parsed and where the System.err messages are emitted; done means the request is handled without parsing errors and the expected Firefox/Windows XP behavior is defined and verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100