vaadin / vaadin/framework

Updating bean in Binder clears component error

Open
#11,153 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation Stale
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

  • Vaadin Framework version 8.5.1

Opposite case of https://github.com/vaadin/framework/issues/11091 :
If use setComponentError() to set an error message for a component and then use a binding to update the bean, the error is never shown. It's not strictly speaking a bug, but can be confusing like in #11091 . This could also be documented in JavaDoc, perhaps in Binder::bind.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Binder::bind entry point and reproduce the reported sequence: set a component error, then update the bean through a binding. Document the resulting behavior in the Binder::bind JavaDoc; done means the documentation clearly explains when the component error is shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.