Setting caption text or icon breaks Upload button layout
Open
Nobody has claimed this yet.
enhancement
workaround
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
- Vaadin Framework version: 8.5.1
- Browser version: any
- Web container name and version: any
- Description of the bug: Setting caption text or icon breaks Upload button layout
- Minimal reproducible example:
Upload upload = new Upload("My Upload",
(filename, mimeType)-> { return null; });
upload.setIcon(VaadinIcons.UPLOAD);
- Expected behavior: A button with an icon and text "My Upload" inside
- Actual behavior: A button with text "Upload" inside and icon + text "My Upload" above the button
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the Java example in Vaadin Framework 8.5.1, using an Upload with the caption "My Upload" and VaadinIcons.UPLOAD. Trace the Upload button layout from that entry point. Done means the icon and caption appear inside one button, with no duplicated text or content above it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100