vaadin / vaadin/framework

Channge method visibility in AbstractListing and AbstractSingleSelect.

Open
#10,611 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

From Forum:

https://vaadin.com/forum/#!/thread/16960117

"I think it would be a good idea to change AbstractListing.java methods setItemCaptionGenerator and getItemCaptionGenerator to have public access.

Also, I think it would be a good idea to have setEmptySelectionAllowed and setEmptySelectionCaption added to AbstractSingleSelect this way we could write generic code that doesn't care if the actual implementation is a ComboBox, NativeSelect or RadioButtonGroup.

This was possible in Vaadin 7 with AbstractSelect"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading AbstractListing.java and AbstractSingleSelect.java, focusing on the named item-caption and empty-selection methods. Compare their APIs with Vaadin 7's AbstractSelect as referenced in the issue. Done means the requested methods are publicly available on the abstract classes and support generic code across the listed component implementations.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.