ViewChangeEvent.getParameterMap() should include query parameters
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 717
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
Vaadin 8.3. Since the addition of HTML5 History API the fragments has been abolished and REST-like paths are now being used. The query parameters were generally not used with the old fragment approach (since they are required to be present before fragment by the URL spec and that made the URLs look weird), but now they're back in the game.
However, the ViewChangeEvent.getParameterMap() still only returns the parameter map from the first path parameter. For example:
http://localhost:8080/myview/param1=value1makes parameterMap return a map{param1=value1}; howeverhttp://localhost:8080/myview?param1=value1makes parameterMap return an empty map
I would suggest the parameterMap to actually return a union of path parameters and query parameters.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ViewChangeEvent.getParameterMap() and trace how path and query parameters are parsed for navigation events. Compare the path-parameter and query-parameter examples in the issue, then verify that the returned map contains the union of both kinds of parameters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend-api-design
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100