vaadin / vaadin/framework

Customizing MoreMenuItem wont work the usual way

Open
#10,573 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

I found a small issue with the ► Symbol of the MoreMenuItem in MenuBar.
First of all, it wasnt clear to me at first, that this isnt a icon.
Using

getMoreMenuItem().setIcon(VaadinIcons.MENU)

would cause this:

unbenannt

Which is quite confusing.

Also, using:

getMoreMenuItem().setText("")

does not remove the Arrow. I needed to use:

getMoreMenuItem().setText(" ")

to remove the Arrow. Now i can use my Hamburger Menu Icon but it is a little offset. So can you change the default ► into an Icon so it is easier to change it?

Thanks in advance

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from MenuBar's MoreMenuItem and inspect how getMoreMenuItem().setIcon() and setText() handle the default arrow symbol. Done means the arrow can be customized or removed without the current spacing and rendering problems; no specific source file or test is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.