vaadin / vaadin/framework

Grid/TreeGrid Editor events are 66% not what it says on the tin.

Open
#10,251 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Stale workaround
Dominant language
Java
Stars
1.8k
Forks
717
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Applies to 8.1.1.

In the Grid/TreeGrid we have the possibility attach listeners to the editor to be notified of:

  • Open
  • Save
  • Cancel

However, these events seem to behave oddly.

In the Grid, in unbuffered mode, mind you, the events behave as follows:

  • Open, called when the editor opens.
  • Save, never called.
  • Cancel, called when the editor loses the focus or is closed by pressing Return.
  • No event is fired when Escape is pressed.

In the TreeGrid, unbuffered mode, the events behave as follows:

  • Open, called when the editor opens.
  • Save, never called.
  • Cancel, called when Escape is pressed.
  • When Return is pressed, the "next" open event fires.

This seems rather unintuitive, or did I miss something there?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported behavior in Grid and TreeGrid with unbuffered editors, exercising Open, Save, Cancel, Return, Escape, focus loss, and closing. Compare the event sequences between both components and determine the intended editor lifecycle semantics. Done means the events consistently reflect the documented actions in both Grid and TreeGrid.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.