vaadin / vaadin/flow-components

UploadManager has no API to react on `upload-error`

Open
#9,765 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement vaadin-upload
Dominant language
Java
Stars
129
Forks
78
Avg merge
17h 42m
Merged PRs (30d)
196

Description

Description

When an upload is blocked (e.g. Mod Security returning 403) the server is not notified about this error.

Expected outcome

There is a server-side event triggered to react on such errors: https://github.com/vaadin/web-components/blob/main/packages/upload/src/vaadin-upload-manager.js#L537

Option 1:

  • file-reject is enhanced to contain also those type of errors

Option 2:

  • upload-error creates a new type of event that developer has to listen on

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/upload/src/vaadin-upload-manager.js around line 537, where the upload-error path is referenced, and trace how upload events are exposed to the server-side component. Decide between extending file-reject or adding a separate event, then verify that a blocked upload can be observed by server-side code.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, javascript
Domain
api, backend, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.