vaadin / vaadin/flow-components
Spreadsheet: Remove Clear All button in favor of API
Open
Nobody has claimed this yet.
refactor
requires new major
v26
vaadin-spreadsheet
- Dominant language
- Java
- Stars
- 129
- Forks
- 78
- Avg merge
- 17h 42m
- Merged PRs (30d)
- 196
Description
The Clear All button in the filter dropdown seems like a bad design decision, seeing as how
- The Select All checkbox can be used to toggle all filers off for that columns, and
- An action for clearing all filters in all columns should not be placed in the filter dropdown in an individual column.
I thereby propose that we remove the Clear All button altogether. Developers can call the existing clearAllFilters method to clear all filters on the table and bind that to a button that they place where they see fit.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Spreadsheet filter dropdown and the existing clearAllFilters method. Check the related component behavior and any existing tests before making the change. Done means the dropdown no longer offers Clear All while developers can still use clearAllFilters to clear filters across the table.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100