vaadin / vaadin/docs

Make the MenuBar overflow example more realistic.

Open Beginner friendly
#2,994 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

design system
Dominant language
AsciiDoc
Stars
38
Forks
225
Avg merge
1d 4h
Merged PRs (30d)
170

Description

The problem with the current docs sample is that the MenuBar is the direct child of a SplitLayout which directly adjusts its width. This hides the fact that in most cases, you need to give the MenuBar a width relative to its container (e.g. 100%), and also make sure the min-width is set to something that allows it to shrink (e.g. var(--lumo-size-m)).

We need to keep the SplitLayout in the sample to showcase the feature properly, but we should wrap the MenuBar in some other component – e.g. a HorizontalLayout – and provide the width and min-width appropriately. This will help developers figure out how to use the overflow feature.


If you think this issue is important, add a 👍 reaction to help the community and maintainers prioritize this issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the MenuBar overflow section linked in the issue and inspect the current SplitLayout sample. Confirm how the sample handles the MenuBar container width and minimum width; it is done when the example uses a wrapper with the stated sizing and still demonstrates overflow correctly.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.